Research Station OC Fix #2259
Merged
Research Station OC Fix #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome more text in the gui
mikerooni
requested changes
Oct 29, 2024
Comment on lines
43
to
45
| if(modifiedRecipe.data.contains("duration_is_total_cwu")) { | ||
| boolean isTotalCWU = modifiedRecipe.data.getBoolean("duration_is_total_cwu"); | ||
| if(isTotalCWU) { |
There was a problem hiding this comment.
These should probably be a single check instead, as the contents of else won't run if duration_is_total_cwu exists but is set to false. (unless that is intended)
mikerooni
approved these changes
Oct 29, 2024
krossgg
pushed a commit
that referenced
this pull request
Oct 31, 2024
screret
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix oc logic for research station allowing, researching multi line in the gui and some discounts with overclocking