Fix Power Substation display when there is no input or output #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
approved these changes
Oct 23, 2024
krossgg
pushed a commit
that referenced
this pull request
Oct 31, 2024
screret
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Passive drain was being subtracted from the netOut of the Power Substation causing the display to read "Time to fill" when there is no input or output for the Power Substation even though the stored charge was going down.
Implementation Details
Passive drain is now a positive netOut
Outcome
Power Substation now displayed "Time to Drain" when there is no input or output for the Power Substation.
Additional Information
Before:
After:
