visual prospecting #1944
Merged
visual prospecting #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks to VisualOres for most of the logic
screret
force-pushed
the
sc/prospecting-map-compat
branch
from
d8b640e to
1b4c171
Compare
I shall leave behind a simple //FIXME as a courtesy.
# Conflicts: # src/main/resources/gtceu.mixins.json
YoungOnionMC
approved these changes
Nov 1, 2024
screret
added a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: YoungOnion <39562198+YoungOnionMC@users.noreply.github.com>
screret
added a commit
that referenced
this pull request
Dec 28, 2024
Co-authored-by: YoungOnion <39562198+YoungOnionMC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
adds JourneyMap & Xaero's minimap/worldmap compat to ore prospecting.
Implementation Details
thanks to VisualOres for most of the logic
Outcome
yay for minimaps
Additional Information
WIP, Xaero's minimap doesn't work correctly and the icons aren't clickable