Fix Positive Crafting Loops in Chemical Recipes #1406
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes positive crafting loops demonstrated in issues #1329 and #1318
How solved:
For #1318: I simply removed the Phosphorus Pentoxide + Water -> Phosphoric Acid recipe, as was the conclusion decided on in the issue thread.
For #1329: I rebalanced the recipe for Methane.
The chemical formula used here was: C + 4H => CH₄. However, in our recipes, it was producing 5k mb of Methane, meaning that the actual formula implemented was: C + 4H => 5CH₄. Obviously, this does not make sense from a chemistry standpoint, as 4 Carbon and 16 Hydrogen are being created from thin air. Unfortunately, this does make the production of Methane slightly more difficult from a player standpoint, but I think it is important to respect the chemistry and follow our rules of 1k mb being 1mol of a fluid.
Outcome:
Closes #1318
Closes #1329
Possible compatibility issue:
Only issues seen are if someone is depending on the production of Phosphoric Acid using Phosphorus Pentoxide, but since this is not the only (nor primary) way of producing this resource, I don't see this being a significant issue.