Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Positive Crafting Loops in Chemical Recipes #1406

Closed
wants to merge 4 commits into from

Conversation

serenibyss
Copy link
Collaborator

What:
Fixes positive crafting loops demonstrated in issues #1329 and #1318

How solved:
For #1318: I simply removed the Phosphorus Pentoxide + Water -> Phosphoric Acid recipe, as was the conclusion decided on in the issue thread.

For #1329: I rebalanced the recipe for Methane.
The chemical formula used here was: C + 4H => CH₄. However, in our recipes, it was producing 5k mb of Methane, meaning that the actual formula implemented was: C + 4H => 5CH₄. Obviously, this does not make sense from a chemistry standpoint, as 4 Carbon and 16 Hydrogen are being created from thin air. Unfortunately, this does make the production of Methane slightly more difficult from a player standpoint, but I think it is important to respect the chemistry and follow our rules of 1k mb being 1mol of a fluid.

Outcome:
Closes #1318
Closes #1329

Possible compatibility issue:
Only issues seen are if someone is depending on the production of Phosphoric Acid using Phosphorus Pentoxide, but since this is not the only (nor primary) way of producing this resource, I don't see this being a significant issue.

@serenibyss
Copy link
Collaborator Author

serenibyss commented Jan 19, 2021

I readded the Phosphorus Pentoxide recipe. We are using the chemical formula: P4O10 + 6H2O => 4(H3PO4), but only had 1 phosphorus pentoxide dust in the recipe. I changed it to take the full 14, or one full mol, so that the equation is balanced. There does seem to be a strange problem where the electrolysis recipe for Phosphoric Acid (H3PO4) does not make any sense chemically, but it does not lead to a positive loop, so it should be "okay" to stay as-is.

@serenibyss
Copy link
Collaborator Author

Closing this as it will be addressed in a different PR, in a more robust way

@serenibyss serenibyss closed this Jan 20, 2021
@serenibyss serenibyss deleted the chemistryfixes branch January 20, 2021 05:33
@serenibyss serenibyss mentioned this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant