-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: facebook like button #395
feat: facebook like button #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to load some js file from FB? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the error message is gone but still can't see it.
Is there anyone else that can test this? On my side it's working so I don't know what to fix :( |
@VWRoli can you help to test it and do some research on your side? |
Sure, I will take a look at it. |
@cavesdev can you tell me what OS and browser do you use? Can you show me a screenshot of the inspected element? My best guess is that we run it locally with http, instead of https, and that causes the problem. Because we load the scripts, just the iframe does not have a height and width. If that is the problem then it should work when we run it on a public domain. Not sure though, it is just a theory. |
Is this useful? https://create-react-app.dev/docs/using-https-in-development/ |
Yes, it was. Set up HTTPS for next, but the like button still does not work. It seems I have to dig deeper. |
Found the problem, staring right in my face. https://developers.facebook.com/docs/plugins/like-button Switched my location to somewhere else and the like button worked. So it is just location and policy issues, the component itself is working fine. |
Oh I see, sorry I'm just seeing your messages! Nice catch, will it be a problem for users on those regions? It will be awkward if some users see the button and some don't. |
oh.... funny problem... the whole Europe? it seems unacceptable... |
@cavesdev can you solve the conflict above and merge your code to branch, we can raise new issue for the problem mentioned above. |
Done! Pulled the most recent changes from web-map-site |
Thanks! |
🎉 This PR is included in version 1.15.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Closes #310
Added a Facebook like button to the tree details page. The like is linked to a specific URL (using the tree id) and users must have a FB account to like the tree.
Type of change
Screenshots
How Has This Been Tested?
Checklist: