-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create 0016-internal-like-system #19
Conversation
Some background, on the web map we are going to add a |
0016-intern-like-system.md
Outdated
@@ -0,0 +1,53 @@ | |||
# Intern Like system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "internal" rather than "intern".
0016-intern-like-system.md
Outdated
|
||
Option #1 | ||
* Risk of "cheating", not being able to identify the user | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't link "likes" to a user account, the user experience may be confusing. A user returning to a previously "liked" tree may see no record that they liked it, causing them to do so again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also worried about this, but there might be some trade-off way to identify the user, by collecting some fingerprint based on browser agent or so? or use cookie, locale storage
0016-intern-like-system.md
Outdated
## Considered Options | ||
|
||
* Option #1 - Intern Like system, to save likes on trees/entities directly | ||
* Option #2 - Your suggestions are welcome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option #2 – Internal Like system linked with Keycloak user authentication system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need to log in before liking/saving an entity is a very common pattern, so would be expected by most users. The "like" button is a great way to ease users into creating an account/wallet with Greenstand.
We can show the like button, then prompt to log in when the user clicks it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer the keycloak/SSO solution
@RubenSmn should we change the status of this PR to something indicating that we have made the decision? I think now we all agree with option 2, right?
|
Agree |
ADR on an Intern Like system
Did some brainstorming with @dadiorchen about the current way of giving a like, resulting in this document
Shortcut to goto the markdown page: https://github.com/RubenSmn/treetracker-decisions/blob/main/0016-intern-like-system.md