Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create 0016-internal-like-system #19

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Conversation

RubenSmn
Copy link
Member

@RubenSmn RubenSmn commented Sep 9, 2022

ADR on an Intern Like system

Did some brainstorming with @dadiorchen about the current way of giving a like, resulting in this document

Shortcut to goto the markdown page: https://github.com/RubenSmn/treetracker-decisions/blob/main/0016-intern-like-system.md

@dadiorchen
Copy link
Contributor

dadiorchen commented Sep 10, 2022

Some background, on the web map we are going to add a like button on trees, currently, we are using FB like button, but it has some limitation, and we don't have the data of that, for example: top liked tree on treetracker.
So another idea is to build our own like button. and also to consider if a generic like button is also useful for admin panel, and android/ios treetracker app?
Please give some input @sebastiangaertner @nmcharlton @Elforama

image

@@ -0,0 +1,53 @@
# Intern Like system

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "internal" rather than "intern".


Option #1
* Risk of "cheating", not being able to identify the user

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't link "likes" to a user account, the user experience may be confusing. A user returning to a previously "liked" tree may see no record that they liked it, causing them to do so again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also worried about this, but there might be some trade-off way to identify the user, by collecting some fingerprint based on browser agent or so? or use cookie, locale storage

## Considered Options

* Option #1 - Intern Like system, to save likes on trees/entities directly
* Option #2 - Your suggestions are welcome

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option #2 – Internal Like system linked with Keycloak user authentication system

Copy link

@nmcharlton nmcharlton Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need to log in before liking/saving an entity is a very common pattern, so would be expected by most users. The "like" button is a great way to ease users into creating an account/wallet with Greenstand.

We can show the like button, then prompt to log in when the user clicks it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer the keycloak/SSO solution

@RubenSmn RubenSmn changed the title create 0016-intern-like-system create 0016-internal-like-system Sep 20, 2022
@dadiorchen
Copy link
Contributor

@RubenSmn should we change the status of this PR to something indicating that we have made the decision? I think now we all agree with option 2, right?

Status: proposed
Input: Welcome from anyone!
Deciders: {list everyone involved in the decision using github handle}
Date: 2022-09-09

@dadiorchen dadiorchen merged commit 7d1f3d5 into Greenstand:main Sep 21, 2022
@sebastiangaertner
Copy link
Contributor

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants