Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

---update_to_target_sdk_34: #1112

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

EsraaAkram
Copy link
Contributor

@EsraaAkram EsraaAkram commented Sep 30, 2024

1-add dataSync service to fit android 14 (setForeground will not run on android 14 without adding the background service type) so I did it 2-adding notification permission
3-handle/remove (AD_ID permission)
both required by google for android 14
4-updating gradle
5-update kotlin version
6-update compose compile ext version
7-change any required code after updating all above

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #1111
Fixes #1113
Fixes #1115

1-add dataSync service to fit android 14 (setForeground will not run on android 14 without adding the background service type) so I did it
2-adding notification permission
3-handle/remove (AD_ID permission)
both required by google for android 14
4-updating gradle
5-update kotlin version
6-update compose compile ext version
7-change any required code after updating all above
update unit test libs
downgrade navigation
java_version_edited
Updates the CI workflow to use Java 17 to support the latest Android Gradle plugin.
Updates the `debug-db` dependency to resolve a 401 Unauthorized error during dependency resolution.
@EngrTaofeek EngrTaofeek merged commit 13e8a65 into Greenstand:master Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants