Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery view and verify editing to Captures #298

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

gwynndp
Copy link
Collaborator

@gwynndp gwynndp commented Jan 16, 2022

Description

Integrate Verify features into CapturesView in preparation for CVAT

  • add gallery view to Captures
  • add buttons to toggle between gallery and table views
  • move toggle logic to CapturesView
  • add GrowerDetail view to CaptureTable
  • add clickable icons to CaptureTable to link to GrowersDetail and CaptureDetailDialog
  • add padding to table
  • make sure gallery pagination can be seen at the bottom of the page
  • format filter and gallery body to shrink for SidePanel

Issue(s) addressed

  • Resolves #269

What kind of change(s) does this PR introduce?

  • Enhancement
  • Refactor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Bugs found

The filters for organization, species, and tags seem to be broken, but the bug was already on the master branch.

@gwynndp gwynndp requested a review from a team as a code owner January 16, 2022 19:38
src/components/Captures/CaptureGallery.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureGallery.test.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureGallery.test.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureTable.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureTable.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/views/CapturesView.js Outdated Show resolved Hide resolved
src/views/CapturesView.test.js Outdated Show resolved Hide resolved
@gwynndp
Copy link
Collaborator Author

gwynndp commented Jan 20, 2022

@TANguyen1893 Thanks for your feedback! I've made those changes.

@gwynndp gwynndp requested a review from TANguyen1893 January 20, 2022 22:35
@gwynndp gwynndp force-pushed the captures-gallery-view branch from 7959d48 to b57a388 Compare January 20, 2022 22:37
src/components/Captures/CaptureGallery.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureGallery.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureGallery.test.js Outdated Show resolved Hide resolved
src/components/Captures/CaptureTable.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/views/CapturesView.test.js Outdated Show resolved Hide resolved
src/views/CapturesView.test.js Outdated Show resolved Hide resolved
@gwynndp gwynndp requested a review from TANguyen1893 January 23, 2022 00:00
@gwynndp gwynndp force-pushed the captures-gallery-view branch from b57a388 to fbcb766 Compare January 23, 2022 00:55
Copy link
Collaborator

@TANguyen1893 TANguyen1893 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM. Let's maybe have another person with more domain knowledge give an approval as well.

@nmcharlton
Copy link
Collaborator

nmcharlton commented Jan 29, 2022

I don't think we're ready for the edit function yet, I'm expecting this to go through some design loops before we land on how we want it to work.

For now, I think the gallery/list toggle would suffice.
We could potentially share and experiment with edit functionality in the dev environment, but we'll need a feature flag to hide that in production.

With that in mind, we don't need the side bar or the selection function.

@gwynndp gwynndp self-assigned this Jan 31, 2022
@gwynndp gwynndp force-pushed the captures-gallery-view branch from fbcb766 to 338c291 Compare February 9, 2022 23:40
@gwynndp gwynndp linked an issue Feb 11, 2022 that may be closed by this pull request
@gwynndp gwynndp force-pushed the captures-gallery-view branch from ec792f8 to c4a444f Compare April 22, 2022 02:34
@nmcharlton nmcharlton added the on hold Awaiting progress on other items before a decision is made label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Awaiting progress on other items before a decision is made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Captures tool with gallery view and tagging/editing
3 participants