-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery view and verify editing to Captures #298
base: master
Are you sure you want to change the base?
Conversation
@TANguyen1893 Thanks for your feedback! I've made those changes. |
7959d48
to
b57a388
Compare
b57a388
to
fbcb766
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM. Let's maybe have another person with more domain knowledge give an approval as well.
I don't think we're ready for the edit function yet, I'm expecting this to go through some design loops before we land on how we want it to work. For now, I think the gallery/list toggle would suffice. With that in mind, we don't need the side bar or the selection function. |
fbcb766
to
338c291
Compare
…add invalidateCaptureCount
ec792f8
to
c4a444f
Compare
Description
Integrate Verify features into CapturesView in preparation for CVAT
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfills these requirements
Bugs found
The filters for organization, species, and tags seem to be broken, but the bug was already on the master branch.