-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing Sub-organizations as dropdown from the organization of a Grower #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynndp
requested changes
Nov 24, 2023
Hello, thank you so much for your consideration.
I was trying to solve this issue
#886 and my
concern is to know from you if that is what you wanted.
About the change fracturing the UI in cards, I'll work on it but it depends
on your reply to the above question.
Any change in the package.json file was not intended and will rectify it.
Regards,
…On Fri, Nov 24, 2023 at 11:57 PM Gwynn Dandridge-Perry < ***@***.***> wrote:
@samwel141 <https://github.com/samwel141>
Off to a nice start! Can you link to the issue that this PR resolves?
I think there are some open questions to answer before we can fully
resolve this.
- Do we want to show all the Sub-Orgs for the Organization on each
grower, or only show the Organization and Sub-Orgs that they belong to
- For a better UX we may need a way to tell the difference between the
Org/Sub-Orgs the grower belongs to and the rest, if we want to list them
all there
In the meantime, there is a display problem with your current
implementation. It is also displaying on the Grower Cards in a jumbled way.
See below:
Screenshot.2023-11-24.at.12.45.11.PM.png (view on web)
<https://github.com/Greenstand/treetracker-admin-client/assets/1761374/a1e87d6b-a6dd-48db-bd4e-6bd0d3ae57e8>
On the card we might just want to list all of the organizations as
comma-separated values to keep it compact, rather than have a dynamic
dropdown.
—
Reply to this email directly, view it on GitHub
<#1124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2PRQ42KOT22IMNCAPRUFO3YGEC5LAVCNFSM6AAAAAA6UKUM5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGA4DANRWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It was installed accedentally or anyhow but not needed
I have put everything clear in the UI can you give feedback on that also |
Looks much better. If you remove your package.json and package-lock.json changes then I'll merge. |
Removed changes in the package.json and package-lock.json, so it is now clear. |
gwynndp
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
managed to show the dropdown list of sub-organizations associated with an organization of a Grower
Issue(s) addressed
Issue number 886 under progress to be resolved
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
What is the new behavior?
now on checking an inline radio button the list of sub-organizations drops from organization name
Breaking change
May close issue: [#886](#886