Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dbname to storage path #67

Closed
wants to merge 3 commits into from

Conversation

joao-zanutto
Copy link
Contributor

No description provided.

Copy link
Contributor

@wwoytenko wwoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is expected this MR will contain --database-name flag and path fixes usage in the list-dumps, restore, etc.

cmd/greenmask/cmd/dump/dump.go Outdated Show resolved Hide resolved
@joao-zanutto
Copy link
Contributor Author

It is expected this MR will contain --database-name flag and path fixes usage in the list-dumps, restore, etc.

I have some questions that I wanted to validate before further development:

  1. From which config should the validate, list-dump, show-dump commands retrieve the dbname from? dump/restore? or should they retrieve the dbname from the new --database-name flag only?
    1.1. Should --database-name be required for validate, list-dump, show-dump commands?
    1.2. Should --database-name be available for dump and restore?
    1.3. Are we introducing a new --origin-database-name that is supposed to define the path to retrieve the dump used in restore?

@wwoytenko
Copy link
Contributor

This was partially discussed here

#68

By the way, there are the answers:

From which config should the validate, list-dump, show-dump commands retrieve the dbname from? dump/restore? or should they retrieve the dbname from the new --database-name flag only?

It is only for restore config and restore command should provide cmd flag as well

Should --database-name be required for validate, list-dump, show-dump commands?

Not it should not be required for them and should not be required at all. If not provided just use the latest dump without DB filtering. This is required only for restore command

Should --database-name be available for dump and restore?

Yes. But it must not affect the connection string or setting related to the connection

Are we introducing a new --origin-database-name that is supposed to define the path to retrieve the dump used in restore?

This is required only for restore command. By the way the best parameter name is --origin-database-name (instead of --database-name) because it is not affects the connection string it is just database name from the origin

@wwoytenko
Copy link
Contributor

I am closing this MR due to no changes. Feel free to open a new one.

@wwoytenko wwoytenko closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants