Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fatal validation error in playground #224

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

JPrisk
Copy link
Contributor

@JPrisk JPrisk commented Oct 22, 2024

running the playground currently causes the following error:

 ERR ValidationWarning={"hash":"300b59e1e8f328f868bd32b03c1af0f0","meta":{"ParameterName":"max_ratio","SchemaName":"humanresources","TableName":"employee","TransformerName":"NoiseDate"},"msg":"parameter is required","severity":"error"}
2024-10-22T06:25:13Z FTL error="fatal validation error"

this change follows the required params as per the docs

@wwoytenko wwoytenko self-requested a review October 22, 2024 06:36
Copy link
Contributor

@wwoytenko wwoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your contribution.
LGTM

@wwoytenko wwoytenko merged commit d58dfb7 into GreenmaskIO:main Oct 22, 2024
2 checks passed
wwoytenko added a commit that referenced this pull request Nov 16, 2024
Closes #224

- Fixed an issue where the table graph used a shared tables list, which was later sorted by the table size scoring function.
- Added a regression test for RuntimeContext to ensure proper functionality.
- Deleted commented code

Co-authored-by: Jan Aagaard Meier <janzeh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants