Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dump/Restore fails when masking tables with a generated column #184

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

wwoytenko
Copy link
Contributor

@wwoytenko wwoytenko commented Aug 27, 2024

  • Added attributes for metadata handling.
  • The restore command now retrieves table definitions from metadata in storage.
  • introduced a new option for restore command --overriding-system-value. if --inserts option is provided generates INSERT statements with OVERRIDING SYSTEM VALUE VALUES
  • Generated columns in toolkit.Table are now excluded from the Columns list
  • Grouped imports
  • Added integration test for generated columns

Closes #183

Co-authored-by: @vinnyjth

* Added attributes for metadata handling.
* The restore command now retrieves table definitions from metadata in storage.
* Added OVERRIDING SYSTEM VALUE to the INSERT statements for columns with GENERATED ALWAYS AS IDENTITY, now set by default.
* Generated columns in toolkit.Table are now excluded from Columns list
* Grouped imports

Closes #183

Co-authored-by: Vincent Wilson vinnyjth@users.noreply.github.com
@wwoytenko wwoytenko self-assigned this Aug 27, 2024
@wwoytenko wwoytenko mentioned this pull request Aug 27, 2024
11 tasks
@wwoytenko wwoytenko added the bug Something isn't working label Aug 28, 2024
* introduced a new option for `restore` command `--overriding-system-value`
* if `--inserts` option is provided generates `INSERT` statements with ` OVERRIDING SYSTEM VALUE VALUES`
* Added doc description for `--overriding-system-value`

Closes #183
@wwoytenko wwoytenko force-pushed the fix/table_with_generated_column branch from 5c2e876 to 65f9684 Compare August 28, 2024 09:16
@wwoytenko wwoytenko added this to the v0.2b2 milestone Aug 28, 2024
@wwoytenko wwoytenko merged commit 8bf72f4 into main Aug 28, 2024
15 checks passed
@wwoytenko wwoytenko deleted the fix/table_with_generated_column branch August 30, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dumping / Restoring fails when masking tables with a generated column.
1 participant