Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on main #82

Closed
wants to merge 8 commits into from
Closed

Fix test failures on main #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab4e7c9
Add expected newlines into test_output
andreww Apr 8, 2024
356f10b
Enable mypy to check out test hints
andreww Apr 9, 2024
d85710b
Fix typo in logging
andreww Apr 9, 2024
199955f
Fix mypy issues in __init__
andreww Apr 9, 2024
058a780
Fix return type and caller of get_runtime_config
andreww Apr 9, 2024
b930f41
Sort out typing problems with check_clean_arguments
andreww Apr 9, 2024
a257b9f
Put type testing reqs into pyptoject.toml
andreww Apr 9, 2024
5d30fb7
Have tests report coverage in CI
andreww Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cats/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def main(arguments=None) -> int:
" specify the scheduler with the -s or --scheduler option"
)
return 1
config, CI_API_interface, location, duration = get_runtime_config(args)
config, CI_API_interface, location, duration, _jobinfo, _PUE = get_runtime_config(args)

########################
## Obtain CI forecast ##
Expand Down
5 changes: 3 additions & 2 deletions cats/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import logging
import sys
from collections.abc import Mapping
from typing import Any
from typing import Any, Union

import requests
import yaml
Expand All @@ -24,7 +24,8 @@
__all__ = ["get_runtime_config"]


def get_runtime_config(args) -> tuple[dict, APIInterface, str, int]:
def get_runtime_config(args) -> tuple[Mapping[str, Any], APIInterface, str, int,
Union[list[tuple[int, float]],None],Any]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of these cases where typing really isn't worth the trouble in my opinion.

"""Return the runtime cats configuration from list of command line
arguments and content of configuration file.

Expand Down