Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add first draft of german translation. #227

Merged
merged 9 commits into from
Jul 26, 2024

Conversation

franziska-warncke
Copy link
Contributor

@franziska-warncke franziska-warncke commented May 2, 2024

Added a first draft of german translation.

What is still needed:

  • A writer review to make sure the translation went well ✅
  • Translation of the images ✅

Copy link
Member

@russelltrow russelltrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations looks great and I've tested locally and it works perfectly.

Copy link
Contributor

@cdhaens cdhaens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@russelltrow
Copy link
Member

Hey @franziska-warncke when might you get chance to review @cdhaens feedback please?

Copy link

@tamarau tamarau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hut ab :) Ein paar Kleinigkeiten meinerseits

@franziska-warncke
Copy link
Contributor Author

Sorry, I was on vacation and after that I got sick. I will look into this now. :)

@franziska-warncke
Copy link
Contributor Author

franziska-warncke commented Jun 28, 2024

@tamarau Can you please have a look again. Thanks 🌻

@russelltrow
Copy link
Member

Hey @franziska-warncke are you happy for us to merge this and then pick-up any further changes later?

I'm aware you've been working on this for a while now.

@franziska-warncke
Copy link
Contributor Author

@russelltrow Let me add the pictures, and then it is ready for merging! :)
I will quickly do that :)

Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
…ta.com>

I, Franziska Warncke <franziska.warncke@nttdata.com>, hereby add my Signed-off-by to this commit: a8052fe

Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
@franziska-warncke
Copy link
Contributor Author

Done! It is now ready to be merged :)

…thub.com>

I, cdhaens <47557938+cdhaens@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 1546348

Signed-off-by: cdhaens <47557938+cdhaens@users.noreply.github.com>
Copy link
Member

@russelltrow russelltrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix a couple of broken images

Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
@franziska-warncke
Copy link
Contributor Author

Good catch! :) This missing picture dont needed a translation - I think this is why I missed that. Now everything should be working, I tested it locally. Please have a look again - maybe there is still something missing. Thank you 🌻

@russelltrow russelltrow merged commit 6bde6e9 into Green-Software-Foundation:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants