-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add first draft of german translation. #227
feat: add first draft of german translation. #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations looks great and I've tested locally and it works perfectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline
i18n/de/docusaurus-plugin-content-docs/current/carbon-efficiency.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/carbon-efficiency.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/carbon-efficiency.mdx
Outdated
Show resolved
Hide resolved
Hey @franziska-warncke when might you get chance to review @cdhaens feedback please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hut ab :) Ein paar Kleinigkeiten meinerseits
i18n/de/docusaurus-plugin-content-docs/current/carbon-awareness.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/carbon-awareness.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/carbon-awareness.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/carbon-awareness.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/carbon-awareness.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/energy-efficiency.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/energy-efficiency.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/energy-efficiency.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/energy-efficiency.mdx
Outdated
Show resolved
Hide resolved
Sorry, I was on vacation and after that I got sick. I will look into this now. :) |
Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
@tamarau Can you please have a look again. Thanks 🌻 |
Hey @franziska-warncke are you happy for us to merge this and then pick-up any further changes later? I'm aware you've been working on this for a while now. |
@russelltrow Let me add the pictures, and then it is ready for merging! :) |
Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
…ta.com> I, Franziska Warncke <franziska.warncke@nttdata.com>, hereby add my Signed-off-by to this commit: a8052fe Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
Done! It is now ready to be merged :) |
…thub.com> I, cdhaens <47557938+cdhaens@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 1546348 Signed-off-by: cdhaens <47557938+cdhaens@users.noreply.github.com>
i18n/de/docusaurus-plugin-content-docs/current/carbon-awareness.mdx
Outdated
Show resolved
Hide resolved
i18n/de/docusaurus-plugin-content-docs/current/climate-commitments.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix a couple of broken images
i18n/de/docusaurus-plugin-content-docs/current/energy-efficiency.mdx
Outdated
Show resolved
Hide resolved
Signed-off-by: Franziska Warncke <franziska.warncke@nttdata.com>
Good catch! :) This missing picture dont needed a translation - I think this is why I missed that. Now everything should be working, I tested it locally. Please have a look again - maybe there is still something missing. Thank you 🌻 |
Added a first draft of german translation.
What is still needed: