Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code touchups #89

Closed
wants to merge 19 commits into from
Closed

Code touchups #89

wants to merge 19 commits into from

Commits on Jul 11, 2012

  1. Remove unnecessary semi colon

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    a3a8c9b View commit details
    Browse the repository at this point in the history

  2. Remove redundent array creation for varargs method

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    0637c41 View commit details
    Browse the repository at this point in the history

  3. Remove unused amqp configuration

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    66ee5e7 View commit details
    Browse the repository at this point in the history

  4. Remove unused performRetention method

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    0a45e1c View commit details
    Browse the repository at this point in the history

  5. Remove redundent initializers

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    ef330e4 View commit details
    Browse the repository at this point in the history

  6. Remove unused variables

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    6aefdf3 View commit details
    Browse the repository at this point in the history

  7. Avoid returning a value when return value is unused

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    3316e19 View commit details
    Browse the repository at this point in the history

  8. Simplify condition as acknowledged must be true

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    3c83a1f View commit details
    Browse the repository at this point in the history

  9. Remove redundent then in multiline if/unless block

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    74cf3ab View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary semicolons

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    50f6a8d View commit details
    Browse the repository at this point in the history

  11. Correct the type of map against which comparison is made

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    0c5c40b View commit details
    Browse the repository at this point in the history

  12. Remove redundent semicolon

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    1f4e20a View commit details
    Browse the repository at this point in the history

  13. Remove unnecessary catch and then rethrow

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    434dc28 View commit details
    Browse the repository at this point in the history

  14. Remove unused field

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    0526212 View commit details
    Browse the repository at this point in the history

  15. Simplify conditional

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    7640ecc View commit details
    Browse the repository at this point in the history

  16. Remove unused field

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    48877e8 View commit details
    Browse the repository at this point in the history

  17. Remove unused field

    @realityforge
    realityforge committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    69de550 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2012

  1. Convert field to local

    @realityforge
    realityforge committed Jul 12, 2012
    Configuration menu
    Copy the full SHA
    b252c7d View commit details
    Browse the repository at this point in the history

  2. Stop passing unused parameter into ServerValueWriterInitializer

    @realityforge
    realityforge committed Jul 12, 2012
    Configuration menu
    Copy the full SHA
    c1e8ae1 View commit details
    Browse the repository at this point in the history