Remove Jest snapshots #4598
Closed
Remove Jest snapshots #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those snapshots are used in frontend tests and need to be in the repository. Snapshot tests compare results of generating the DOM tree for the component under test with the stored snapshot, helping us to spot unintentional changes in the component tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some accidentally committed snapshots directories of Jest and adds them to the
.gitignorefile to prevent this from happening in the future.Refs jestjs/jest#1650
Refs https://facebook.github.io/jest/docs/en/snapshot-testing.html