Merge branch 'feature/GTSHOPIFY-7' into main-dev #10

Triggered via push September 17, 2024 14:29

phapsidesGT

pushed db6fe7c

main-dev

Status Failure

Total duration 1m 5s

Artifacts –

ci.yml

on: push

Annotations

4 errors, 34 warnings, and 24 notices

layout/theme.liquid#L301

[ParserBlockingJavaScript] Missing async or defer attribute on script tag

layout/theme.liquid#L302

[ParserBlockingJavaScript] Missing async or defer attribute on script tag

sections/hero-banner.liquid#L108

[ImgWidthAndHeight] Missing width and height attributes

sections/product-slider.liquid#L122

[ImgWidthAndHeight] Missing width and height attributes

layout/password.liquid#L179

[AssetPreload] For better performance, prefer using the preload_tag filter

layout/password.liquid#L184

[AssetPreload] For better performance, prefer using the preload_tag filter

layout/theme.liquid#L271

[AssetPreload] For better performance, prefer using the preload_tag filter

layout/theme.liquid#L276

[AssetPreload] For better performance, prefer using the preload_tag filter

layout/theme.liquid#L301

[RemoteAsset] Asset should be served by the Shopify CDN for better performance.

layout/theme.liquid#L302

[RemoteAsset] Asset should be served by the Shopify CDN for better performance.

layout/theme.liquid#L303

[RemoteAsset] Asset should be served by the Shopify CDN for better performance.

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

sections/bulk-quick-order-list.liquid#L5

[NestedSnippet] Too many nested snippets

sections/collage.liquid#L95

[LiquidTag] Use {% liquid ... %} to write multiple tags

sections/featured-product.liquid#L383

[NestedSnippet] Too many nested snippets

sections/featured-product.liquid#L383

[NestedSnippet] Too many nested snippets

sections/featured-product.liquid#L383

[NestedSnippet] Too many nested snippets

sections/featured-product.liquid#L476

[UnusedAssign] `seo_media` is never used

sections/hero-banner.liquid#L108

[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others

sections/main-cart-footer.liquid#L67

[LiquidTag] Use {% liquid ... %} to write multiple tags

sections/main-collection-banner.liquid#L27

[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others

sections/main-collection-product-grid.liquid#L155

[LiquidTag] Use {% liquid ... %} to write multiple tags

sections/main-product.liquid#L465

[NestedSnippet] Too many nested snippets

sections/main-product.liquid#L465

[NestedSnippet] Too many nested snippets

sections/main-product.liquid#L465

[NestedSnippet] Too many nested snippets

sections/main-product.liquid#L717

[UnusedAssign] `seo_media` is never used

sections/main-search.liquid#L259

[LiquidTag] Use {% liquid ... %} to write multiple tags

sections/predictive-search.liquid#L145

[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others

sections/product-slider.liquid#L122

[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others

sections/quick-order-list.liquid#L23

[NestedSnippet] Too many nested snippets

sections/quick-order-list.liquid#L23

[NestedSnippet] Too many nested snippets

snippets/cart-drawer.liquid#L502

[LiquidTag] Use {% liquid ... %} to write multiple tags

snippets/quick-order-list.liquid#L183

[LiquidTag] Use {% liquid ... %} to write multiple tags

snippets/quick-order-product-row.liquid#L1

[UnusedSnippet] This snippet is not used

templates/gift_card.liquid#L96

[AssetPreload] For better performance, prefer using the preload_tag filter

templates/gift_card.liquid#L101

[AssetPreload] For better performance, prefer using the preload_tag filter

Theme Check

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Lighthouse

sections/announcement-bar.liquid#L171