Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove small flash #89

Closed
daviddavo opened this issue Jun 13, 2022 · 2 comments
Closed

[BUG] Remove small flash #89

daviddavo opened this issue Jun 13, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@daviddavo
Copy link
Member

When you change the selected DAO on the dropdown, after everything is finished, it makes a little flash.

This can happen because it enters the "global" load state just a fraction of a second.

It happens just when the URL is changing.

@daviddavo daviddavo added the bug Something isn't working label Jun 13, 2022
@daviddavo daviddavo added this to the 1.1.0 milestone Jun 13, 2022
@daviddavo
Copy link
Member Author

When the url changes, the display_page callback is called. As there is no change, it will raise a PreventUpdate exception. Nevertheless, the loading state is still entered, so the loading screen will be shown a few miliseconds until the PreventUpdate exception is raised.

We could either change all out callbacks system, or use Plotly Dash Pages #88 included in v2.5.0

daviddavo added a commit that referenced this issue Jun 13, 2022
@daviddavo
Copy link
Member Author

I split the callback into two. One that is called when the url changes, and one that modifies the layout. The one that modifies the layout is only called when the first part of the url (the platform) changes, so there won't be any visual glitches.

The code is now a bit more clean too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant