Make preload.sh POSIX-compliant #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made `preload.sh` fully POSIX-compliant, meaning it can now run on any POSIX-compatible shell, not just `bash`.
|
Please leave out the automatic building part. |
|
Done. |
|
This changes the behavior of the script and will break using it as an installed script. It relies on using a relative path from the script's own path. Not sure how to deal with that. |
thestinger
force-pushed
the
main
branch
5 times, most recently
from
51a59c3 to
c97263e
Compare
Letgamer
reviewed
Jan 13, 2025
| @@ -1,6 +1,7 @@ | |||
| #!/bin/bash | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
wouldn't it be better to use #!/usr/bin/env sh ?
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made
preload.shfully POSIX-compliant, meaning it can now run on any POSIX-compatible shell, not justbash.