You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR of this - perf is linked with libdw from elfutils. libdw from elfutils-179 that we were using, used to dlopen("libdebuginfod.so"). On certain systems, as reported in #340 , this dlopen() call led to some DSOs to be loaded, and those DSOs crashed perf.
We don't need libdebuginfod, I doubt this thing even runs anywhere, and anyway we don't use dwarf perf by default currently, so this definitely shouldn't be the default.
Recent elfutils versions (see elfutils 4ced3010ad11) fix this and avoid loading the DSO unless libdebuginfod is actually to be called into. So I upgraded elfutils, and then upgraded libzstd because new elfutils requires newer libzstd than available in apt.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hopefullyresolves #340, pending my testing.