java: Profile Zing with AP & refactor version checks #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jongy
commented
Jun 2, 2022
•
Jongy
commented
- Profile Zing if Zing VM > 18
- Don't profile HS 6 - it crashes
- Refactor & document version checks
|
Is this tested? |
Ofc. Tested on HS and Zing 22 (didn't test on old Zing tho, I don't have one at hand. I'll patch the checked version to 23 and make sure it now fails) |
|
Doing a few more checks & refactors, will update here |
|
@adi-benz ready |
Jongy
changed the title
|
See PR desc as well |
adi-benz
approved these changes
Jun 2, 2022
unrelated failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.