utils: perf: Catch another case of perf permissions error #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[17:21:12] Couldn't create the Java profiler, continuing without it Traceback (most recent call last): File "gprofiler/profilers/factory.py", line 41, in get_profilers File "gprofiler/profilers/java.py", line 637, in __init__ File "gprofiler/profilers/java.py", line 654, in _init_ap_mode File "gprofiler/utils/perf.py", line 19, in can_i_use_perf_events File "gprofiler/utils/__init__.py", line 265, in run_process gprofiler.exceptions.CalledProcessError: Command '['/tmp/_MEIYxgsVy/gprofiler/resources/perf', 'record', '-o', '/dev/null', '--', '/bin/true']' returned non-zero exit status 255. stdout: b'' stderr: b'Permission error mapping pages.\nConsider increasing /proc/sys/kernel/perf_event_mlock_kb,\nor try again with a smaller value of -m/--mmap_pages.\n(current value: 4294967295,0)\n'
What about changing it to |
Yes, let's do that |
adi-benz
suggested changes
May 2, 2022
adi-benz
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know, maybe it's just best to catch all errors and treat them as "False" instead of failing the
JavaProfilercompletely. On the other hand, that might hide real errors. Well, keeping it this way for now.