Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Install self-hosted requirements & run on dirty environment #351

Merged
merged 2 commits into from
May 1, 2022

Conversation

Jongy
Copy link
Contributor

@Jongy Jongy commented Apr 27, 2022

2 types of fixes:

  1. Upon each run, install the necessary requirements (that come preinstalled on gh hosted runners but not on self-hosted obv)
  2. Fix things that expect to run on clean env

Those all I fixed manually when I released 1.2.22, making sure that it works fine next release.

@Jongy Jongy added the enhancement New feature or request label Apr 27, 2022
@Jongy Jongy requested a review from adi-benz April 27, 2022 15:55
@@ -5,7 +5,7 @@ set -ue
# Copyright (c) Granulate. All rights reserved.
# Licensed under the AGPL3 License. See LICENSE.md in the project root for license information.
#
# Used in CI and checks that last pushed tag is grater that last existing tag.
# Used in CI and checks that last pushed tag is greater that last existing tag.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, btw, still doesn't work. But off for another PR

@@ -117,7 +121,7 @@ jobs:
- name: Build gProfiler executable
run: |
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
docker buildx create --name multiarch --driver docker-container --use
docker buildx create --name multiarch --driver docker-container --use --node multiarch0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is multiarch0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default "node name" it uses for the buildx builder with --name multiarch

@Jongy Jongy merged commit 4af57d6 into master May 1, 2022
@Jongy Jongy deleted the ci-self-hosted-fixes branch May 1, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants