fix #29. put object assign args in create/update plugin

packages/gqlify-firestore/src/index.ts

@@ -66,7 +66,6 @@ export class FirestoreDataSource implements DataSource {
   }
 
   public async create(payload: any): Promise<any> {
-    payload = Object.assign({}, payload);
     const ref = await this.db.collection(this.path).add(payload);
     await ref.update({ id: ref.id });
     const doc = await ref.get();

packages/gqlify/src/plugins/create.ts

@@ -132,12 +132,17 @@ export default class CreatePlugin implements Plugin {
 
     return {
       [mutationName]: async (root, args, context) => {
+        // args may not have `hasOwnProperty`.
+        // https://github.com/Canner/gqlify/issues/29
+        const data = {...args.data};
+
+        // no relationship or other hooks
         if (!wrapCreate) {
-          return dataSource.create(args.data);
+          return dataSource.create(data);
         }
 
         // wrap
-        const createContext: CreateContext = {data: args.data, response: {}};
+        const createContext: CreateContext = {data, response: {}};
         await wrapCreate(createContext, async ctx => {
           ctx.response = await dataSource.create(ctx.data);
         });

packages/gqlify/src/plugins/update.ts

@@ -144,13 +144,18 @@ export default class UpdatePlugin implements Plugin {
     return {
       [mutationName]: async (root, args, context) => {
         const whereUnique = this.whereInputPlugin.parseUniqueWhere(args.where);
+        // args may not have `hasOwnProperty`.
+        // https://github.com/Canner/gqlify/issues/29
+        const data = {...args.data};
+
+        // no relationship or other hooks
         if (!wrapUpdate) {
-          await dataSource.update(whereUnique, args.data);
+          await dataSource.update(whereUnique, data);
           return args.where;
         }
 
         // wrap
-        const updateContext: UpdateContext = {where: args.where, data: args.data, response: {}};
+        const updateContext: UpdateContext = {where: args.where, data, response: {}};
         await wrapUpdate(updateContext, async ctx => {
           await dataSource.update(whereUnique, ctx.data);
         });

packages/gqlify/test/fixtures/oneModel.graphql

@@ -22,5 +22,5 @@ type User @GQLifyModel(dataSource: "memory", key: "users") {
   status: STATUS
   attributes: JSON
   location: Location
-  note: [Note!]!
+  note: [Note!]
 }

packages/gqlify/test/testsuites/oneModel.ts

@@ -80,6 +80,37 @@ export function testSuits() {
     expect(user).to.deep.equal(createUser);
   });
 
+  it('should create record with args', async () => {
+    const userData = {
+      username: 'wwwy3y3',
+      email: 'wwwy3y3@canner.io',
+    };
+    const query = `
+      mutation {
+        createUser (data: {username: "${userData.username}", email: "${userData.email}"}) {${fields}}
+      }
+    `;
+    const {createUser} = await (this as any).graphqlRequest(query);
+    expect(createUser).to.have.property('id');
+    expect(createUser).to.deep.include(userData);
+
+    // query to see if exists
+    const {users: createdUsers} = await (this as any).graphqlRequest(`
+      query {
+        users {${fields}}
+      }
+    `);
+    expect(createdUsers[0]).to.deep.equal(createUser);
+
+    // query one
+    const {user} = await (this as any).graphqlRequest(`
+      query {
+        user(where: {id: "${createUser.id}"}) {${fields}}
+      }
+    `);
+    expect(user).to.deep.equal(createUser);
+  });
+
   it('should create many records to test where & pagination filter', async () => {
     // create 20 users, make 10 of them having status NOT_OK
     const createdUsers = await Promise.all(
@@ -184,6 +215,34 @@ export function testSuits() {
     expect(certainUser.username).to.deep.equal(updateUserVariables.data.username);
   });
 
+  it('should update with args', async () => {
+    const createUserVariables = {
+      data: fakeUserData(),
+    };
+    const createUserQuery = `
+      mutation ($data: UserCreateInput!) {
+        createUser (data: $data) {${fields}}
+      }
+    `;
+    const {createUser} = await (this as any).graphqlRequest(createUserQuery, createUserVariables);
+
+    const newUsername = faker.internet.userName();
+    const updateUserQuery = `
+      mutation {
+        updateUser (where: {id: "${createUser.id}"}, data: {username: "${newUsername}"}) { id }
+      }
+    `;
+    const {updateUser} = await (this as any).graphqlRequest(updateUserQuery);
+    expect(updateUser.id).to.be.equal(createUser.id);
+
+    const {user: certainUser} = await (this as any).graphqlRequest(`
+      query {
+        user(where: {id: "${createUser.id}"}) {${fields}}
+      }
+    `);
+    expect(certainUser.username).to.deep.equal(newUsername);
+  });
+
   it('should delete', async () => {
     const createUserVariables = {
       data: fakeUserData(),