Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to run eslint #329

Merged
merged 3 commits into from
May 21, 2024
Merged

fix: unable to run eslint #329

merged 3 commits into from
May 21, 2024

Conversation

shioju
Copy link
Collaborator

@shioju shioju commented May 13, 2024

This PR fixes incompatibility issue between prettier 3 and eslint-plugin-prettier 4, but upgrading to eslint-plugin-prettier 5. prettier/eslint-plugin-prettier#562

This PR also upgrades to the eslint flat config format, and adds npm scripts for running eslint.

  • I've kept this PR as small as possible (~500 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1 reviewer
  • I've tested existing features (website scan, sitemap, custom flow) in both node index and cli
  • I've synced this fork with GovTechSG repo
  • I've added/updated unit tests
  • I've added/updated any necessary dependencies in package[-lock].json npm audit, portable installation on GitHub Actions

@shioju shioju requested a review from younglim May 13, 2024 01:36
Copy link
Collaborator

@younglim younglim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, npm test command can run

@younglim younglim merged commit 2464d09 into master May 21, 2024
1 check passed
younglim pushed a commit that referenced this pull request May 22, 2024
* fix: eslint was not working

* feat: upgrade to eslint flat config

* fix: use latest ecma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants