♻️ refactor(*): selecteur not combiné [DS-3589] #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keryanS
commented
Sep 11, 2023
keryanS
commented
- Remplacement des selecteurs :not(.selecteurA, .selecteurB) par :not(.selecteurA):not(.selecteurB) dans le js des composants : accordion, navigation, sidemenu, translate, transcription
- La séparation par des virgules est une fonctionnalité assez récente qui n’est pas si bien supportée que ça sur d’anciennes versions de plusieurs navigateurs (firefox, safari, edge…)
keryanS
added
correctif
zellerbaptiste
approved these changes
Sep 12, 2023
keryanS
changed the title
colinux
reviewed
Sep 26, 2023
| @@ -5,7 +5,7 @@ const COLLAPSE = api.internals.ns.selector('collapse'); | |||
|
|
|||
| export const TranscriptionSelector = { | |||
| TRANSCRIPTION: TRANSCRIPTION, | |||
| COLLAPSE: `${TRANSCRIPTION} > ${COLLAPSE}, ${TRANSCRIPTION} > *:not(${TRANSCRIPTION}, ${COLLAPSE}) > ${COLLAPSE}, ${TRANSCRIPTION} > *:not(${TRANSCRIPTION}, ${COLLAPSE}) > *:not(${TRANSCRIPTION}, ${COLLAPSE}) > ${COLLAPSE}`, | |||
| COLLAPSE: `${TRANSCRIPTION} > ${COLLAPSE}, ${TRANSCRIPTION} > *:not(${TRANSCRIPTION}:not(${COLLAPSE}) > ${COLLAPSE}, ${TRANSCRIPTION} > *:not(${TRANSCRIPTION}):not(${COLLAPSE}) > *:not(${TRANSCRIPTION}):not(${COLLAPSE}) > ${COLLAPSE}`, | |||
There was a problem hiding this comment.
bonjour, je crois qu'il manque une ) juste avant :not sur le premiere sélecteur corrigé :
*:not(${TRANSCRIPTION}):not(${COLLAPSE})
à la place de
*:not(${TRANSCRIPTION}:not(${COLLAPSE})
lab9fr
requested changes
Sep 26, 2023
src/analytics/script/integration/component/transcription/transcription-selector.js
Outdated
Show resolved
Hide resolved
…cription-selector.js
lab9fr
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.