-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix(form, input): met a jour les espacements des icônes [DS-3474, DS-3504] #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zellerbaptiste
added
correctif
Quelque chose ne fonctionne pas
à vérifier
maj 1.10.0
labels
Sep 5, 2023
zellerbaptiste
changed the title
🐛 fix(input-base): met a jour les espacements des icônes []
🐛 fix(input-base): met a jour les espacements des icônes [DS-3474]
Sep 5, 2023
…735) - Les cookies obligatoires doivent être systématiquement cochés
keryanS
approved these changes
Sep 15, 2023
keryanS
requested changes
Sep 15, 2023
@@ -50,11 +50,11 @@ | |||
|
|||
@include has-icon { | |||
#{ns(input)} { | |||
@include padding-right(10v); | |||
@include padding-right(11v); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12v
background-size: spacing.space(4v) spacing.space(4v); | ||
@include padding-right(9v); | ||
@include padding-right(11v); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passer à 12v pour avoir 16px à droite et a gauche de l'icone (comme sur password)
zellerbaptiste
force-pushed
the
fix/input-icon-spacing
branch
from
September 21, 2023 09:34
74e2890
to
944a368
Compare
zellerbaptiste
changed the title
🐛 fix(input-base): met a jour les espacements des icônes [DS-3474]
🐛 fix(input-base): met a jour les espacements des icônes [DS-3474, DS-3504]
Sep 21, 2023
keryanS
approved these changes
Sep 21, 2023
keryanS
changed the title
🐛 fix(input-base): met a jour les espacements des icônes [DS-3474, DS-3504]
🐛 fix(form, input): met a jour les espacements des icônes [DS-3474, DS-3504]
Sep 21, 2023
lab9fr
approved these changes
Oct 2, 2023
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
padding-right
à 44px sur les champs de saisie avec icônefr-fieldset__content
pour la version dépréciée