Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(form, input): met a jour les espacements des icônes [DS-3474, DS-3504] #766

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Sep 5, 2023

  • place l’icône à 16px du bord droit des champs de saisie
  • ajuste le padding-right à 44px sur les champs de saisie avec icône
  • corrige la largeur des class fr-fieldset__content pour la version dépréciée

@zellerbaptiste zellerbaptiste added correctif Quelque chose ne fonctionne pas à vérifier maj 1.10.0 labels Sep 5, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Sep 5, 2023
@zellerbaptiste zellerbaptiste self-assigned this Sep 5, 2023
@zellerbaptiste zellerbaptiste changed the title 🐛 fix(input-base): met a jour les espacements des icônes [] 🐛 fix(input-base): met a jour les espacements des icônes [DS-3474] Sep 5, 2023
…735)

- Les cookies obligatoires doivent être systématiquement cochés
@@ -50,11 +50,11 @@

@include has-icon {
#{ns(input)} {
@include padding-right(10v);
@include padding-right(11v);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12v

background-size: spacing.space(4v) spacing.space(4v);
@include padding-right(9v);
@include padding-right(11v);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passer à 12v pour avoir 16px à droite et a gauche de l'icone (comme sur password)

@zellerbaptiste zellerbaptiste changed the title 🐛 fix(input-base): met a jour les espacements des icônes [DS-3474] 🐛 fix(input-base): met a jour les espacements des icônes [DS-3474, DS-3504] Sep 21, 2023
@keryanS keryanS requested a review from lab9fr September 21, 2023 16:36
@keryanS keryanS changed the title 🐛 fix(input-base): met a jour les espacements des icônes [DS-3474, DS-3504] 🐛 fix(form, input): met a jour les espacements des icônes [DS-3474, DS-3504] Sep 21, 2023
@lab9fr lab9fr added Prêt and removed à valider labels Oct 2, 2023
@keryanS keryanS merged commit 3b40607 into dev-1.11.0 Nov 7, 2023
4 checks passed
@keryanS keryanS deleted the fix/input-icon-spacing branch November 7, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctif Quelque chose ne fonctionne pas maj 1.10.0 Prêt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants