♻️ refactor(link): rel noopener & title target blank [DS-2509] #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryanS
changed the title
tool/example/heading.ejs
Outdated
| @@ -17,7 +17,7 @@ | |||
| <% | |||
| for (const d of doc) { | |||
| %> | |||
| <li><a href="<%= d.url %>" target="_blank"><%= d.title %></a></li> | |||
| <li><a href="<%= d.url %>" target="_blank" rel="noopener"><%= d.title %></a></li> | |||
There was a problem hiding this comment.
Pourquoi ne pas utiliser la même méthode ici ?
zellerbaptiste
approved these changes
Aug 28, 2023
keryanS
force-pushed
the
refactor/noopener-blank
branch
from
d7a1932
to
f91d6c2
Compare
lab9fr
requested changes
Sep 8, 2023
tool/example/decorator.ejs
Outdated
| const targetBlankData = () => { | ||
| const attr = {}; | ||
| attr.target = '_blank'; | ||
| attr.rel = 'noopener'; |
There was a problem hiding this comment.
Suggested change
| attr.rel = 'noopener'; | |
| attr.rel = 'noopener external'; |
keryanS
changed the title
lab9fr
approved these changes
Oct 3, 2023
keryanS
force-pushed
the
refactor/noopener-blank
branch
from
9a54d17
to
14fc4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout de l'attribut rel="noopener" et title="intitulé - nouvelle fenêtre" à tous les liens en target="_blank"