Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048,DS-3054] #519

Merged
merged 10 commits into from
Jun 19, 2023

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Jan 24, 2023

Lorsque la page est scrollable, un décalage se produit à l'ouverture d'une modal (la page étant figé elle n'est plus scrollable).

Une marge est donc appliquée à l'ouverture de la modale pour simuler la barre de scroll et ainsi éviter le mouvement du contenu en arrière plan.

@keryanS keryanS added the correctif Quelque chose ne fonctionne pas label Jan 24, 2023
@keryanS keryanS requested a review from lab9fr January 24, 2023 14:48
@keryanS keryanS self-assigned this Jan 24, 2023
@keryanS keryanS changed the title feat(core, modal): décalage scrollbar à l'ouverture/fermeture modale [DS-3048] feat(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048] [DS-3054] Jan 25, 2023
@lab9fr lab9fr changed the title feat(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048] [DS-3054] feat(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048,DS-3054] Jan 26, 2023
@lab9fr lab9fr added this to the 1.10.0 milestone Feb 28, 2023
@lab9fr lab9fr changed the base branch from dev-1.9.0 to dev-1.10.0 February 28, 2023 11:10
@lab9fr lab9fr changed the title feat(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048,DS-3054] fix(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048,DS-3054] Mar 27, 2023
@lab9fr lab9fr changed the title fix(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048,DS-3054] 🐛 fix(core, modal): décalage scrollbar à l'ouverture/fermeture modale & fix scroll behavior [DS-3048,DS-3054] Mar 27, 2023
@lab9fr lab9fr force-pushed the feat/padding-scroll-locker branch from 4b25531 to a055fcb Compare June 19, 2023 10:46
@lab9fr lab9fr merged commit d1b7d58 into dev-1.10.0 Jun 19, 2023
@lab9fr lab9fr deleted the feat/padding-scroll-locker branch June 19, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctif Quelque chose ne fonctionne pas maj 1.9.3 Prêt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflit de fonctionnement entre les modales et le style scroll-behaviour: smooth
2 participants