🐛 fix(sidemenu, navigation, header): correctif template ejs [DSFR-44] #1073
+35
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryanS
reviewed
Jan 24, 2025
| <%- include('./sidemenu-menu.ejs', { sidemenuItem : item }); %> | ||
| <% } else {%> | ||
| <% item.classes = item.kind === 'button' ? [`${prefix}-sidemenu__btn`] : [`${prefix}-sidemenu__link`]; %> | ||
| <% item.classes = item.type === 'button' ? [`${prefix}-sidemenu__btn`] : [`${prefix}-sidemenu__link`]; %> | ||
| <% if (item.active) item.attributes['aria-current'] = 'page'; %> | ||
| <%- include('../../../../core/template/ejs/action/action', { action: { ...item } }) %> |
There was a problem hiding this comment.
J'ai pas testé, mais on risque pas de se retouver avec un au niveau du template action ?
There was a problem hiding this comment.
Oui, je me suis posé la question, mis dans le pire des cas on a un type button, ce qui marche sur action.
There was a problem hiding this comment.
c'est surtout que c'est raccord avec la navigation, si on veut changer, il faudrait changer partout, ce qui peut être bien également. on pourrait aussi appeler cette prop template, c'est au final ce qu'elle est.
zellerbaptiste
approved these changes
Jan 24, 2025
lab9fr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctif des variables du sidemenu