Skip to content

Commit

Permalink
✨ feat(header): retire l'attribut aria-haspopup du bouton burger [DS-…
Browse files Browse the repository at this point in the history
…3679] (#856)
  • Loading branch information
zellerbaptiste authored Jan 30, 2024
1 parent b52fe4b commit 1036284
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/analytics/example/spa/agnostic/index.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
Rechercher
</button>
<button class="<%= prefix %>-btn--menu <%= prefix %>-btn" data-<%= prefix %>-opened="false"
aria-controls="modal-124" aria-haspopup="menu" id="button-125" title="Menu">
aria-controls="modal-124" id="button-125" title="Menu">
Menu
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/analytics/example/spa/angular/_index.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ app.config(function($routeProvider) {
<button class="fr-btn--search fr-btn" data-fr-opened="false" aria-controls="modal-122" id="button-123" title="Rechercher" >
Rechercher
</button>
<button class="fr-btn--menu fr-btn" data-fr-opened="false" aria-controls="modal-124" aria-haspopup="menu" id="button-125" title="Menu">
<button class="fr-btn--menu fr-btn" data-fr-opened="false" aria-controls="modal-124" id="button-125" title="Menu">
Menu
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/analytics/example/spa/react/index.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<button class="fr-btn--search fr-btn" data-fr-opened="false" aria-controls="modal-122" id="button-123" title="Rechercher" >
Rechercher
</button>
<button class="fr-btn--menu fr-btn" data-fr-opened="false" aria-controls="modal-124" aria-haspopup="menu" id="button-125" title="Menu">
<button class="fr-btn--menu fr-btn" data-fr-opened="false" aria-controls="modal-124" id="button-125" title="Menu">
Menu
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/analytics/example/spa/vue/index.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<button class="<%= prefix %>-btn--search <%= prefix %>-btn" data-<%= prefix %>-opened="false" aria-controls="modal-122" id="button-123" title="Rechercher" data-<%= prefix %>-js-modal-button="true" >
Rechercher
</button>
<button class="<%= prefix %>-btn--menu <%= prefix %>-btn" data-<%= prefix %>-opened="false" aria-controls="modal-124" aria-haspopup="menu" id="button-125" title="Menu">
<button class="<%= prefix %>-btn--menu <%= prefix %>-btn" data-<%= prefix %>-opened="false" aria-controls="modal-124" id="button-125" title="Menu">
Menu
</button>
</div>
Expand Down
3 changes: 1 addition & 2 deletions src/component/header/deprecated/template/ejs/navbar.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ let label;
title: label,
attributes: {
...attrs,
'aria-controls': navbar.menu.modalId,
'aria-haspopup': 'menu'
'aria-controls': navbar.menu.modalId
},
label: label,
id: navbar.menu.id
Expand Down
3 changes: 1 addition & 2 deletions src/component/header/template/ejs/navbar.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ let label;
title: label,
attributes: {
...attrs,
'aria-controls': navbar.menu.modalId,
'aria-haspopup': 'menu'
'aria-controls': navbar.menu.modalId
},
label: label,
id: navbar.menu.id
Expand Down

0 comments on commit 1036284

Please sign in to comment.