Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sky revamped #289

Merged
merged 6 commits into from
Jan 14, 2024
Merged

Feature/sky revamped #289

merged 6 commits into from
Jan 14, 2024

Conversation

JucanAndreiDaniel
Copy link
Contributor

To test

  1. Select random time and see if sky and fog color are properly set

Scene

  • FeatureFlags reverted to right value

Testing

  • Tested with PCVR
  • Tested with Pico / Quest

@JaXt0r
Copy link
Contributor

JaXt0r commented Jan 14, 2024

A few hints:

  1. Waterfalls are too bright and won'T be handled by the shadow.
    image

  2. Please create a FeatureFlag to enable/disable this fog feature. (I think we will have a performance setting in the future anyways. Therefore let's start with a feature flag.)

  3. Movement of clouds looks awesome.

@JucanAndreiDaniel
Copy link
Contributor Author

A few hints:

1. Waterfalls are too bright and won'T be handled by the shadow.
   ![image](https://private-user-images.githubusercontent.com/120568393/296610976-e7190edb-e718-4d10-a3a4-3986a39f620d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDUyNTkwNTEsIm5iZiI6MTcwNTI1ODc1MSwicGF0aCI6Ii8xMjA1NjgzOTMvMjk2NjEwOTc2LWU3MTkwZWRiLWU3MTgtNGQxMC1hM2E0LTM5ODZhMzlmNjIwZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMTE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDExNFQxODU5MTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmFiZWFjYTlhYjhlNzI0MDljNmI3YmI1YTQ5MmE1MTkzZTgzODZkZWM5MmNhYjhlYTM5MDkyMmUwNWE2MjMzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9._uNrdpID6wTdLuH7-b4Q9z8Lm0eYhNVGI6NOOdu5wcg)

2. Please create a FeatureFlag to enable/disable this fog feature. (I think we will have a performance setting in the future anyways. Therefore let's start with a feature flag.)

3. Movement of clouds looks awesome.

actually the waterfall relies on modifying the water shader to have fog applied, which i want to work a bit after i finish most of the barrier stuff

Assets/GothicVR/Scripts/Data/SkyLayerData.cs Outdated Show resolved Hide resolved
Assets/GothicVR/Scripts/Data/SkyState.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/Data/SkyState.cs Show resolved Hide resolved
Assets/GothicVR/Scripts/World/GameTime.cs Outdated Show resolved Hide resolved
Assets/GothicVR/Shaders/Skybox.shader Outdated Show resolved Hide resolved
Assets/GothicVR/Shaders/Skybox.shader Outdated Show resolved Hide resolved
Assets/GothicVR/Shaders/Skybox.shader Outdated Show resolved Hide resolved
Assets/GothicVR/Shaders/Skybox.shader Show resolved Hide resolved
@JucanAndreiDaniel JucanAndreiDaniel merged commit ff107e2 into main Jan 14, 2024
@JucanAndreiDaniel JucanAndreiDaniel deleted the feature/sky-revamped branch January 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create distance fog like in original gothic Skybox (e.g. barrier effects)
2 participants