Bugfix/Font-wrap-wrong #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested your feature. Is this the intended outcome? If you can share a before - after image, then I can test better. |
JaXt0r
suggested changes
Jan 14, 2024
| horizontalBearingX = 0, | ||
| horizontalAdvance = w | ||
| }, | ||
| index = (uint)i, | ||
| sprite = newSprite | ||
| sprite = newSprite, | ||
| scale = -1 |
There was a problem hiding this comment.
Why a scale of -1? Sounds wrong tbh.
There was a problem hiding this comment.
Hm. Seems you flip about every text element. Why?
This is intended before after
these are taken from the discord where i posted what was the issue |
JaXt0r
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix glyph metrics to have the glyphs with the right orientation and fix all labels from main menu
To test