Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vob particlefx #251

Merged
merged 19 commits into from
Nov 7, 2023
Merged

Feature/vob particlefx #251

merged 19 commits into from
Nov 7, 2023

Conversation

JaXt0r
Copy link
Contributor

@JaXt0r JaXt0r commented Nov 3, 2023

This PR is intended to merge first Particle implementation. It's definitely WIP (e.g. fire) but the creation flow is fine. I want to merge it and will work on it at a later stage again.

To test

  1. Activate FeatureFlag: enableVobParticles (under Experimental)
  2. Check if you see properly flying leaves inside woods
  3. Check if you see broken fire particles (expected)

Checklist

(Please judge for yourself which entry is valuable for your PR)

Scene

  • FeatureFlags reverted to right value

Testing

  • Merged main into this branch and tested with the latest features
  • Tested with PCVR
  • Tested with Pico / Quest

Dependencies

  • If libphoenix-shared.dll is changed, .so is also changed

@JaXt0r JaXt0r added the quick Just a small improvement, but still worth the time. ;-) label Nov 3, 2023
Copy link
Contributor

@JucanAndreiDaniel JucanAndreiDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for a first approach for particles, but need to keep in mind that the emitter gameobject is culled, so the particles might disappear when walking too far away from the emitter

// Renderer module
{
var rendererModule = go.GetComponent<ParticleSystemRenderer>();
TextureManager.I.SetTexture(pfx.visName, rendererModule.material);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default selected shader for the material is URP/Lit which takes a ton of time to compile (even if it's one time only)
Maybe we can change it do Simple Lit or another shader which doesn'y take that much to compile

Suggested change
TextureManager.I.SetTexture(pfx.visName, rendererModule.material);
var standardShader = Shader.Find("Universal Render Pipeline/Simple Lit");
var material = new Material(standardShader);
rendererModule.material = material;
TextureManager.I.SetTexture(pfx.visName, rendererModule.material);

@JaXt0r
Copy link
Contributor Author

JaXt0r commented Nov 7, 2023

Nice teamwork @JucanAndreiDaniel . It's been a pleasure as alway. :-)

@JaXt0r JaXt0r merged commit 6683333 into main Nov 7, 2023
@JaXt0r JaXt0r deleted the feature/vob-particlefx branch November 7, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick Just a small improvement, but still worth the time. ;-)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants