Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scripts] C_SFX and C_SNDSYS_CFG class articles #140

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Scripts] C_SFX and C_SNDSYS_CFG class articles #140

merged 2 commits into from
Oct 15, 2024

Conversation

muczc1wek
Copy link
Contributor

@muczc1wek muczc1wek commented Oct 14, 2024 •
edited
Loading

kamilkrzyskow
kamilkrzyskow approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@kamilkrzyskow kamilkrzyskow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the micro issues and squash merge when you're ready ✌️

docs/zengin/scripts/classes/c_sfx.md Outdated Show resolved Hide resolved
docs/zengin/scripts/classes/c_sndsys_cfg.md Outdated Show resolved Hide resolved
docs/zengin/scripts/classes/c_sndsys_cfg.md Outdated Show resolved Hide resolved
@muczc1wek muczc1wek merged commit eaea536 into Gothic-Modding-Community:dev Oct 15, 2024
1 check passed
@kamilkrzyskow
Copy link
Collaborator

Ugh, my mistake, I thought there is only one commit, and adding new ones would require a squash 🤦
Sorry about that, since you prepared 2 atomic commits (big enough to be their own commit) you could've of course rebased them instead of squashing. At least the squash adds the #140 reference in the commit 😄

@muczc1wek
Copy link
Contributor Author

I don't care if it is one commit or two, PR is merged and that's what counts 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilkrzyskow kamilkrzyskow kamilkrzyskow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muczc1wek @kamilkrzyskow