Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] Improve VDFS article #134

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

muczc1wek
Copy link
Contributor

Demo

I don't know if tools section is better in my variant or the previous was more readable

@kamilkrzyskow
Copy link
Collaborator

I preferred the dashed list, but perhaps even better would be a table with ❌ and ✔️ for each feature.
CLI: ❌ ✔️
Compression: ❌ ✔️

@muczc1wek
Copy link
Contributor Author

obraz

@kamilkrzyskow is that good enough? I have no idea how to style it.

@auronen
Copy link
Collaborator

auronen commented Oct 11, 2024

The table looks really nice and clear, it will be great once we start adding more vdfs tools.

@kamilkrzyskow
Copy link
Collaborator

Apart of the comment LGTM @muczc1wek 👍

The table looks good, if there are more tools we might consider adding a div wrapper with some CSS class to center the content, but not necessary currently.

@kamilkrzyskow
Copy link
Collaborator

You can squash merge when you're ready 🫡

@muczc1wek muczc1wek merged commit 7b371af into Gothic-Modding-Community:dev Oct 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants