Multiline UDAs broken

[thehunmonkgroup]

Multiline string UDAs, which worked fine in TaskWarrior 2.5.3 with the addition of #2132 are now broken in latest release:

[:~/git/vit] 2.x+ ± task 1 modify notes:"one"
Modifying task 1 'test'.
Modified 1 task.
TASKRC override: /tmp/tmp.XCtk4fQYjA.vit/taskrc
[:~/git/vit] 2.x+ ± task 1
TASKRC override: /tmp/tmp.XCtk4fQYjA.vit/taskrc
 
Name          Value                               
ID            1                                   
Description   test                                
Status        Pending                             
Entered       2021-10-11 (Mon) (15min)
Last modified 2021-10-11 (Mon) (2s)               
Virtual tags  PENDING READY UDA UNBLOCKED
UUID          a5e07137-2ecb-4372-9e89-422e11aa9068
Urgency          0
Notes         one                                 
 
[:~/git/vit] 2.x+ ± task 1 modify notes:"two
$
$three"
Modifying task 1 'notes:two
 
three'.
Modified 1 task.
TASKRC override: /tmp/tmp.XCtk4fQYjA.vit/taskrc
[:~/git/vit] 2.x+ ± task 1
TASKRC override: /tmp/tmp.XCtk4fQYjA.vit/taskrc
 
Name          Value                               
ID            1                                   
Description   notes:two                           
 
              three                               
Status        Pending                             
Entered       2021-10-11 (Mon) (15min)
Last modified 2021-10-11 (Mon) (2s)               
Virtual tags  PENDING READY UDA UNBLOCKED
UUID          a5e07137-2ecb-4372-9e89-422e11aa9068
Urgency          0
Notes         one 

Possibly related to #2283 ?

[tbabej]

@thehunmonkgroup I am actually unable to reproduce this working on 2.5.3. Am I doing something incorrectly here?

[warrior@tw-v2.5.3 ~]$ task add test notes:"one
> two
> three"
Created task 2.
[warrior@tw-v2.5.3 ~]$ task 2
No command specified - assuming 'information'.

Name          Value                               
ID            2                                   
Description   test notes:one
              two
              three
Status        Pending                             
Entered       2021-11-09 13:09:07 (2s)
Last modified 2021-11-09 13:09:07 (2s)            
Virtual tags  LATEST PENDING READY UNBLOCKED
UUID          8ebf1352-c91d-4cdd-a05a-ed2938c82da3
Urgency          0

[warrior@tw-v2.5.3 ~]$ task udas

Name     Type   Label    Allowed Values Default Usage Count
notes    string Notes                           0          
priority string Priority H,M,L,                 0

2 UDAs defined

[tbabej]

(same problem occurs on 2.5.1)

[thehunmonkgroup]

From my initial post:

Multiline string UDAs, which worked fine in TaskWarrior 2.5.3 with the addition of #2132 are now broken in latest release

It's broken in 2.6.1, have not tried HEAD.

[tbabej]

@thehunmonkgroup Perhaps a misunderstanding. I tested this with 2.6.1 release, 2.5.3 release and 2.5.1 release. The mutli-line UDA, at least according to the above reproduction steps (unless I made a mistake), did not work in any of the releases.

Which obviously seems to be in contrary to your experience (since you've been using this successfully with onenote I'm assuming), hence we need to figure out what's wrong with the reproducer 🤔

[tbabej]

In other words, I can reproduce the bug, but I can't reproduce a working version, which makes this rather challenging to bisect 😅

[thehunmonkgroup]

Perhaps bisect from #2132 ?

[tbabej]

Is that the version you suspect you were using? I can try to investigate.

Edit: Now I see what you meant. I misread the original issue description as #2132 causing the problem 😅

[thehunmonkgroup]

For me, the bug is not present on 2.5.3, and is present on all 2.6.x stuff I've tried.

[tbabej]

I am still unable to reproduce this, but yesterday I discovered that adding additional layer of quoting allows a multi-line value to be parsed correctly. Would that work as a workaround?

[warrior@tw-v2.6.1 ~]$ task add test note:"'one
> two
> three
> four
> '"
Created task 1.
[warrior@tw-v2.6.1 ~]$ task 1 info

Name          Value                               
ID            1                                   
Description   test
Status        Pending                             
Entered       2021-11-22 14:54:31 (2s)
Last modified 2021-11-22 14:54:31 (2s)            
Virtual tags  LATEST PENDING READY UDA UNBLOCKED
UUID          285fb1b5-878c-4849-845e-90858aeb32de
Urgency          0
Note          one                                 
              two                                 
              three                               
              four                                

[thehunmonkgroup]

I can confirm that your workaround works for both 2.5.3 and the develop branch. Curious why this would be necessary though?

The first quotes should pass the newlines along to TaskWarrior, right?

[thehunmonkgroup]

Curious if there's been any progress on this, I'm not really sure what all I can do to help, but I'd be happy to help in any way I can, as this has affected a tool I maintain, and is preventing me from upgrading to 2.6.x: thehunmonkgroup/onenote#3

[tbabej]

As far as I could tell, this is a consequence of the new parser that was introduced in 2.6 (development branch at the time) and later backported to 2.5.2. Unclear what can be done right now, I tried fixing it but it did not seem straightforward.

Given there is a relatively simple workaround which could be utilized in onenote, and as far as I can tell, is backwards compatible, would going down that path be an option?

[thehunmonkgroup]

My main concern with the workaround is that it feels brittle, especially given that we can't determine exactly why it's needed. That seems a recipe for another round of bug reports once the root cause is discovered and fixed.