Remove pynotify notifications. #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to #336, they don't work. It also looks like they just use gobject notifications under the hood.. and we support that directly. No use keeping an option around that doesn't work, right? ;)
ryneeverett
approved these changes
Mar 15, 2017
bugwarrior/notifications.py
Outdated
|
|
||
| pynotify.Notification("Bugwarrior", message, logo_path).show() | ||
| elif notify_backend == 'gobject': | ||
| elif notify_backend == 'gobject' or notify_backend == 'pynotify': |
There was a problem hiding this comment.
nitpick: Would it be better to set notify_backend = 'gobject' after the warning so this deprecated setting is handled in just one place? Seems simpler to cleanup if and when it's removed and less confusing if references to historical features are all in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #336, they don't work. It also looks like they just use
gobject notifications under the hood.. and we support that directly.
No use keeping an option around that doesn't work, right? ;)
"Fixes" #336.