Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maps Chinese version #241

Open
alphayang opened this issue Dec 18, 2015 · 2 comments
Open

Add support for maps Chinese version #241

alphayang opened this issue Dec 18, 2015 · 2 comments

Comments

@alphayang
Copy link

Maps has a Chinese version to apply regulation and legal under http://www.google.cn/maps and api point is http://www.google.cn/maps/api/js. It's public access in China while .com one is not available because Great Fire Wall.

Add a country or other optional parameter to specify the Maps is very useful for web developers.

BTW, in my experience, http://www.google.cn/maps/api/js and https://www.google.com/maps/api/js share the same codebase and functional but different tiles resources.

@ebidel
Copy link
Contributor

ebidel commented Dec 18, 2015

I wonder if there's a way we can load the correct version automatically rather than exposing a country properties most developers will never use?

@gutenye
Copy link

gutenye commented Feb 6, 2016

All services target to worldwide or developers in China need this feature.

Use country property or baseURL is very accurate, the automatic ways are request timeout, timezone or ip address location.

For who are interested, I've forked and hacked it at https://github.com/gutenye/google-map

ebidel added a commit that referenced this issue Aug 4, 2016
ebidel pushed a commit that referenced this issue Aug 4, 2016
Fixes #241 - allows api loads in china
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants