fix: Set the client DialContext to the connhelper dialer DOCKER_HOST is present #9521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng an SSH DOCKER_HOST Summary: Fixes GoogleContainerTools#9484 Test Plan: Tested skaffold over a ssh connection to minikube. This was tested with and without GoogleContainerTools#9512 in place.
Closed
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Nov 20, 2024
… accessing an SSH DOCKER_HOST (GoogleContainerTools#9521)" This reverts commit 5fae4ba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes #9484
Fixes: #9484
Description
This was tested with and without #9512 in place.
Test Plan: Tested skaffold over a ssh connection to minikube.