fix: send maxRetries property when it is specified by the user in a cloud run job manifest #9475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9452
Description
With this change, we'll force the inclusion of the
maxRetries
property whenever it's explicitly specified in a Cloud Run Job manifest, even if its value is 0. Only when it's not specified in the manifest will it be omitted, and Cloud Run will set its default value to 3.When unmarshalling manifests into run.Job (google.golang.org/api/run/v1), the
spec.template.spec.template.spec.maxRetries
field is mapped to a non-pointer int64. This makes it impossible to distinguish between a 0 value from an unspecified property in the manifest and a 0 value explicitly set by the user. With this logic, we check the manifests to determine if the property was explicitly set.