Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove global helm flags from flags sent to skaffold filter #9212

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Dec 6, 2023

Fixes: #9124

Description
When using Skaffold's Helm deployer or renderer we invoke some helm commands with the --post-renderer flag to invoke the Skaffold binary again triggering the skaffold filter command. We are sending the helm.flags.global values to the flags used by skaffold filter; helm.flags.global is meant to be used in all the helm commands invoked by Skaffold, not in skaffold filter. Skaffold execution can fail because of this. This PR removes the helm.flags.global when running skaffold filter.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 295 lines in your changes are missing coverage. Please review.

Comparison is base (290280e) 70.48% compared to head (7c00572) 63.65%.
Report is 1076 commits behind head on main.

Files Patch % Lines
cmd/skaffold/app/cmd/exec.go 16.32% 40 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/filter.go 47.27% 22 Missing and 7 partials ⚠️
cmd/skaffold/app/cmd/lsp.go 28.12% 23 Missing ⚠️
cmd/skaffold/app/cmd/verify.go 23.33% 23 Missing ⚠️
cmd/skaffold/app/cmd/fix.go 51.16% 17 Missing and 4 partials ⚠️
cmd/skaffold/app/cmd/inspect_job_manifest_paths.go 60.00% 15 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/inspect_namespaces.go 50.00% 13 Missing and 1 partial ⚠️
...md/skaffold/app/cmd/inspect_config_dependencies.go 45.83% 12 Missing and 1 partial ⚠️
cmd/skaffold/app/cmd/lint.go 42.85% 12 Missing ⚠️
cmd/skaffold/app/cmd/inspect_build_env.go 60.71% 11 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9212      +/-   ##
==========================================
- Coverage   70.48%   63.65%   -6.83%     
==========================================
  Files         515      632     +117     
  Lines       23150    32545    +9395     
==========================================
+ Hits        16317    20717    +4400     
- Misses       5776    10236    +4460     
- Partials     1057     1592     +535     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renzodavid9 renzodavid9 marked this pull request as ready for review December 8, 2023 19:03
@renzodavid9 renzodavid9 merged commit c4af00e into GoogleContainerTools:main Dec 11, 2023
14 checks passed
@renzodavid9 renzodavid9 deleted the issue-9124 branch December 11, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global helm flags passed to skaffold post renderer
2 participants