fix: remove global helm flags from flags sent to skaffold filter
#9212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9124
Description
When using Skaffold's Helm deployer or renderer we invoke some helm commands with the
--post-renderer
flag to invoke the Skaffold binary again triggering theskaffold filter
command. We are sending thehelm.flags.global
values to the flags used byskaffold filter
;helm.flags.global
is meant to be used in all the helm commands invoked by Skaffold, not inskaffold filter
. Skaffold execution can fail because of this. This PR removes thehelm.flags.global
when runningskaffold filter
.