Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements #911

Merged
merged 9 commits into from
Aug 23, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 18, 2018

No description provided.

@dgageot dgageot requested review from balopat and r2d4 as code owners August 18, 2018 12:56
@codecov-io
Copy link

codecov-io commented Aug 18, 2018

Codecov Report

Merging #911 into master will increase coverage by 2.56%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   39.52%   42.09%   +2.56%     
==========================================
  Files          61       61              
  Lines        2616     2497     -119     
==========================================
+ Hits         1034     1051      +17     
+ Misses       1469     1332     -137     
- Partials      113      114       +1
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/wait.go 29.41% <ø> (+18.17%) ⬆️
pkg/skaffold/kubernetes/colorpicker.go 100% <ø> (ø) ⬆️
pkg/skaffold/util/util.go 49.29% <ø> (+5.54%) ⬆️
pkg/skaffold/build/local/bazel.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/kubectl/cli.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/local/docker.go 21.05% <0%> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 57.31% <100%> (ø) ⬆️
pkg/skaffold/runner/changes.go 100% <100%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 50.61% <62.5%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b6546...97fc6bf. Read the comment docs.

@dgageot dgageot force-pushed the misc-improvements branch from abcff1c to 1d69a56 Compare August 21, 2018 08:08
@dgageot
Copy link
Contributor Author

dgageot commented Aug 22, 2018

ping @balopat, this is a collection of small things that should be easy to review.
I can break the PR if you prefer.

@dgageot dgageot force-pushed the misc-improvements branch from 3f37de4 to ec1eb92 Compare August 22, 2018 17:37
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the misc-improvements branch from ec1eb92 to 97fc6bf Compare August 22, 2018 19:49
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dgageot dgageot merged commit 50c4983 into GoogleContainerTools:master Aug 23, 2018
@dgageot dgageot deleted the misc-improvements branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants