Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support post-renderer for helm deployer. #9100

Merged

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Sep 25, 2023

Fixes: #8063, #6951, #6707

  • support user-defined post-renderer for helm deployer
    • Skaffold uses post-renderer to set up labels, perform image replacement, and adding debugging annotations when deploying with helm
    • The post-renderer flag provided by helm only supports one executable that allows users to customize their deploy manifests after helm rendering, and if multiples are specified, last writer wins, this behavior makes skaffold override writes user-defined post-rendered
    • This pr changes this by wrapping user-defined post-renderer into skaffold filter.
    • The implementation parses --post-renderer from helm install flags defined in skaffold.yaml without any validation, this is the same as the old behavior.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #9100 (02d4f89) into main (290280e) will decrease coverage by 7.06%.
Report is 1033 commits behind head on main.
The diff coverage is 48.33%.

❗ Current head 02d4f89 differs from pull request most recent head 3a8d6d9. Consider uploading reports for the commit 3a8d6d9 to get more accurate results

@@            Coverage Diff             @@
##             main    #9100      +/-   ##
==========================================
- Coverage   70.48%   63.43%   -7.06%     
==========================================
  Files         515      628     +113     
  Lines       23150    32331    +9181     
==========================================
+ Hits        16317    20508    +4191     
- Misses       5776    10262    +4486     
- Partials     1057     1561     +504     
Files Coverage Δ
cmd/skaffold/app/cmd/commands.go 97.61% <100.00%> (+0.35%) ⬆️
cmd/skaffold/app/cmd/config.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/flags.go 93.00% <100.00%> (+2.18%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
... and 41 more

... and 432 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review September 27, 2023 16:01
@renzodavid9 renzodavid9 merged commit a64de4a into GoogleContainerTools:main Oct 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] Add integration test which uses helm hooks
2 participants