Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inject namespace from rendered manifests in post deploy hooks #9090

Merged

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Sep 14, 2023

Fixes: #8357

Description
This PR adds the logic to inject the namespaces from the rendered manifests into the post deploy hooks. The manifests namespaces are assigned every time a new deployment happens.

Follow-up Work
Check this behaviour for the Sync hooks which use the same namespaces env variable

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #9090 (61d4e26) into main (290280e) will decrease coverage by 7.07%.
Report is 1028 commits behind head on main.
The diff coverage is 48.90%.

@@            Coverage Diff             @@
##             main    #9090      +/-   ##
==========================================
- Coverage   70.48%   63.42%   -7.07%     
==========================================
  Files         515      628     +113     
  Lines       23150    32294    +9144     
==========================================
+ Hits        16317    20482    +4165     
- Misses       5776    10251    +4475     
- Partials     1057     1561     +504     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <0.00%> (ø)
... and 41 more

... and 432 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 force-pushed the issue-8357-deploy-hooks branch from 51097a3 to 61d4e26 Compare September 14, 2023 18:16
@renzodavid9 renzodavid9 marked this pull request as ready for review September 15, 2023 11:05
@renzodavid9 renzodavid9 merged commit 1c3944b into GoogleContainerTools:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After-deploy hooks: the value of SKAFFOLD_NAMESPACES is always default for kubectl deployer
2 participants