Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add docker to the LTS container images #8905

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

plumpy
Copy link
Collaborator

@plumpy plumpy commented Jun 22, 2023

This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run.

This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #8905 (2a95ccf) into main (290280e) will decrease coverage by 6.72%.
The diff coverage is 48.99%.

@@            Coverage Diff             @@
##             main    #8905      +/-   ##
==========================================
- Coverage   70.48%   63.77%   -6.72%     
==========================================
  Files         515      622     +107     
  Lines       23150    31589    +8439     
==========================================
+ Hits        16317    20145    +3828     
- Misses       5776     9934    +4158     
- Partials     1057     1510     +453     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 414 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz
Copy link
Contributor

kokoro job is broken, we can ignore that at the moment.

@plumpy plumpy merged commit 85c478f into GoogleContainerTools:main Jun 22, 2023
@plumpy plumpy deleted the add_docker branch June 22, 2023 16:46
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit to plumpy/skaffold that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
plumpy added a commit that referenced this pull request Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since
they depend on docker to run.

(cherry picked from commit 85c478f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants