-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add docker to the LTS container images #8905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run.
Codecov Report
@@ Coverage Diff @@
## main #8905 +/- ##
==========================================
- Coverage 70.48% 63.77% -6.72%
==========================================
Files 515 622 +107
Lines 23150 31589 +8439
==========================================
+ Hits 16317 20145 +3828
- Misses 5776 9934 +4158
- Partials 1057 1510 +453
... and 414 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
Jun 22, 2023
kokoro job is broken, we can ignore that at the moment. |
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Jun 22, 2023
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run. (cherry picked from commit 85c478f)
plumpy
added a commit
that referenced
this pull request
Jun 22, 2023
plumpy
added a commit
that referenced
this pull request
Jun 22, 2023
plumpy
added a commit
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where kpt functions wouldn't work in rendering since they depend on docker to run.