Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file change tracking #888

Merged
merged 2 commits into from
Aug 10, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 9, 2018

Adding some tests to the code that detects file changes.
Also simplifies the code used to track changes.

This should make the watch mode consume less CPU.
I'll run some tests before getting this PR merged to know how much

@dgageot dgageot requested review from balopat and r2d4 as code owners August 9, 2018 12:52
@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #888 into master will decrease coverage by 0.11%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   38.38%   38.27%   -0.12%     
==========================================
  Files          54       56       +2     
  Lines        2519     2576      +57     
==========================================
+ Hits          967      986      +19     
- Misses       1441     1476      +35     
- Partials      111      114       +3
Impacted Files Coverage Δ
pkg/skaffold/watch/changes.go 76% <77.27%> (ø)
pkg/skaffold/watch/watch.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a4fef...cd7b85b. Read the comment docs.

@dgageot dgageot changed the title Test of the day Improve file change tracking Aug 9, 2018
@balopat
Copy link
Contributor

balopat commented Aug 9, 2018

@dgageot, the new tests seem to be failing, can you check?

@dgageot
Copy link
Contributor Author

dgageot commented Aug 9, 2018

@balopat Works on my machine. lol

@dgageot dgageot force-pushed the tests-changes branch 5 times, most recently from e221954 to 296b526 Compare August 10, 2018 11:51
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Copy link
Contributor Author

dgageot commented Aug 10, 2018

@balopat should be good now. Funny to see the coverage decrease when I added tests and removed some code.

@dgageot dgageot merged commit 3f11067 into GoogleContainerTools:master Aug 10, 2018
@dgageot dgageot deleted the tests-changes branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants