Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic to interrupt a k8sjob logs as soon as it fails (#8847) #8871

Conversation

renzodavid9
Copy link
Contributor

This is a cherry pick to fix #8839 inv2.5:

@renzodavid9 renzodavid9 changed the base branch from main to release/v2.5 June 8, 2023 20:18
@renzodavid9 renzodavid9 force-pushed the cherry-pick-k8s-ca-issue branch from 96be367 to 82b507d Compare June 8, 2023 20:21
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.5@bb0ed01). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 76d6532 differs from pull request most recent head 4020378. Consider uploading reports for the commit 4020378 to get more accurate results

@@               Coverage Diff               @@
##             release/v2.5    #8871   +/-   ##
===============================================
  Coverage                ?   63.93%           
===============================================
  Files                   ?      620           
  Lines                   ?    31460           
  Branches                ?        0           
===============================================
  Hits                    ?    20115           
  Misses                  ?     9842           
  Partials                ?     1503           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…ainerTools#8847)

* fix: logic to interrupt a k8sjob logs as soon as it fails and change in delete order, now the job is deleted before its pods

* test: integration tests to check when a log should not appear in the output

(cherry picked from commit c7c72a1)
@renzodavid9 renzodavid9 force-pushed the cherry-pick-k8s-ca-issue branch from 76d6532 to 4020378 Compare June 9, 2023 16:57
@renzodavid9 renzodavid9 marked this pull request as ready for review June 9, 2023 17:44
@renzodavid9 renzodavid9 requested review from plumpy and ericzzzzzzz June 9, 2023 17:44
@renzodavid9 renzodavid9 merged commit 1c990f2 into GoogleContainerTools:release/v2.5 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CustomActions] K8s - logs can get stuck when running with timeout
2 participants