Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upload deps lisences #8747

Merged

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented May 5, 2023

Description

  • upload deps licenses to prepare to internal signing
  • add check to ensure go.mod changes and licenses are in sync

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #8747 (9a730c6) into main (290280e) will decrease coverage by 6.07%.
The diff coverage is 50.00%.

❗ Current head 9a730c6 differs from pull request most recent head 3320a2f. Consider uploading reports for the commit 3320a2f to get more accurate results

@@            Coverage Diff             @@
##             main    #8747      +/-   ##
==========================================
- Coverage   70.48%   64.41%   -6.07%     
==========================================
  Files         515      617     +102     
  Lines       23150    31171    +8021     
==========================================
+ Hits        16317    20079    +3762     
- Misses       5776     9590    +3814     
- Partials     1057     1502     +445     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 407 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz changed the title Upload deps lisences chore: Upload deps lisences May 5, 2023
@ericzzzzzzz ericzzzzzzz force-pushed the upload-deps-lisences branch from 33a1e10 to a5660ef Compare May 5, 2023 17:37
@ericzzzzzzz ericzzzzzzz force-pushed the upload-deps-lisences branch from a5660ef to 3320a2f Compare May 5, 2023 17:38
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review May 5, 2023 19:12
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@aaron-prindle aaron-prindle merged commit 9682905 into GoogleContainerTools:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants