Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for helm deployment with `packaged' option #696

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

hypnoglow
Copy link
Contributor

Following #682

Also added testdata/foo helm chart (created using helm create foo) for further testing.

@hypnoglow
Copy link
Contributor Author

hypnoglow commented Jun 18, 2018

I believe CI check issues are unrelated to this PR.

@hypnoglow hypnoglow force-pushed the add-tests-for-packaged branch from c5f06d6 to 1b4f864 Compare June 19, 2018 07:45
@dlorenc
Copy link
Contributor

dlorenc commented Jun 19, 2018

@hypnoglow can you rebase? the CI issues should be fixed at HEAD.

@hypnoglow hypnoglow force-pushed the add-tests-for-packaged branch from 1b4f864 to f41ea86 Compare June 19, 2018 18:36
@dlorenc dlorenc added the kokoro:run runs the kokoro jobs on a PR label Jun 19, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 19, 2018
@hypnoglow
Copy link
Contributor Author

@dlorenc done 👌

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@dgageot
Copy link
Contributor

dgageot commented Jun 20, 2018

@hypnoglow I had to update the branch to merge it. Can you just confirm you are ok with that?

@hypnoglow
Copy link
Contributor Author

@dgageot No problem, as long as everything works

@r2d4 r2d4 added the kokoro:run runs the kokoro jobs on a PR label Jun 20, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 20, 2018
@dgageot dgageot merged commit ce5c505 into GoogleContainerTools:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants